On 1/7/20 2:14 PM, Arnd Bergmann wrote: > The new shutdown callback causes a link failure: > > drivers/ata/ahci_brcm.c: In function 'brcm_ahci_shutdown': > drivers/ata/ahci_brcm.c:552:8: error: implicit declaration of function 'brcm_ahci_suspend'; did you mean 'brcm_ahci_shutdown'? [-Werror=implicit-function-declaration] > ret = brcm_ahci_suspend(&pdev->dev); > ^~~~~~~~~~~~~~~~~ > > Remove the incorrect #ifdef and use __maybe_unused annotations > instead to make this more robust. > > Fixes: 7de9b1688c1d ("ata: ahci_brcm: Add a shutdown callback") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> good catch, thanks! -- Florian