Hi Rob, thanks for the feedback, I am fixing up the patches with some hammering and tinkering. Just answering this question: On Tue, Dec 31, 2019 at 7:44 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > Why do you need to describe the drives in DT for IDE? They are > discoverable, right? And unlike SATA, the power to master and slave is > shared. It is because of a related patch set by Guenter Roeck where we add thermal zones to the thermal sensors found in the drives. To associate these with a thermal zone as defined in device tree, I need a handle on the drive. See my mail to hwmon for an example: https://lore.kernel.org/linux-hwmon/CACRpkdb8rehAPKE2Zu-Jf4TSE2m6ks91vZdrVy+HitijabeVbg@xxxxxxxxxxxxxx/ Yours, Linus Walleij