On 12/25/19 7:46 PM, Jens Axboe wrote: > On 12/25/19 8:34 PM, Florian Fainelli wrote: >> >> >> On 12/11/2019 5:31 AM, Hans de Goede wrote: >>> Hi, >>> >>> On 10-12-2019 19:53, Florian Fainelli wrote: >>>> Hi Jens, >>>> >>>> The first 4 patches are fixes and should ideally be queued up/picked up >>>> by stable. The last 4 patches add support for BCM7216 which is one of >>>> our latest devices supported by this driver. >>>> >>>> Patch #2 does a few things, but it was pretty badly broken before and it >>>> is hard not to fix all call sites (probe, suspend, resume) in one shot. >>>> >>>> Please let me know if you have any comments. >>>> >>>> Thanks! >>> >>> The entire series looks good to me: >>> >>> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> >>> >>> Regards, >> >> Thanks Hans, Jens is this good to go from your perspective? > > I'll queue 1-4 up for 5.5 and mark for stable, then add 5-8 for > 5.6. Thanks! It looks like I will have two incremental changes on top to minimize the number of resources that get cycled through during EPROBE_DEFER and also ensure that the 7216 reset line gets properly managed with a call to reset_control_reset() per review feedback from the reset controller maintainer. -- Florian
