On Wed, Dec 18, 2019 at 07:15:07PM -0500, Martin K. Petersen wrote: > > Guenter, > > > This driver solves this problem by adding support for reading the > > temperature of SATA drives from the kernel using the hwmon API and > > by adding a temperature zone for each drive. > > My working tree is available here: > > https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git/log/?h=5.6/drivetemp > > A few notes: > > - Before applying your patch I did s/satatemp/drivetemp/ > > - I get a crash in the driver core during probe if the drivetemp module > is loaded prior to loading ahci or a SCSI HBA driver. This crash is > unrelated to my changes. Haven't had time to debug. > > - I tweaked your ATA detection heuristics and now use the cached VPD > page 0x89 instead of fetching one from the device. > > - I also added support for reading the temperature log page on SCSI > drives. > > - Tested with a mixed bag of about 40 SCSI and SATA drives attached. > > - I still think sensor naming needs work. How and where are the > "drivetemp-scsi-8-140" names generated? > Quick one: In libsensors, outside the kernel. The naming is generic, along the line of <driver name>-<bus name>-<bus index>-<slot>. > I'll tinker some more but thought I'd share what I have for now. > Thanks for sharing. I'll be out on vacation until January 1. I'll look at the code after I am back. Guenter > -- > Martin K. Petersen Oracle Linux Engineering
