Hi Michael,
On Thu, Sep 26, 2019 at 5:54 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
> The Atari platform device setup now provides a platform device
> for the Falcon IDE interface. Use this in place of the simple platform
> device set up in the old pata_falcon probe code.
>
> Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
>
> --
Should be a triple dash.
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Minor nit below.
> --- a/drivers/ata/pata_falcon.c
> +++ b/drivers/ata/pata_falcon.c
> @@ -120,24 +119,22 @@ static int pata_falcon_set_mode(struct ata_link *link,
> .set_mode = pata_falcon_set_mode,
> };
>
> -static int pata_falcon_init_one(void)
> +static int __init pata_falcon_init_one(struct platform_device *pdev)
> {
> + struct resource *res;
> struct ata_host *host;
> struct ata_port *ap;
> - struct platform_device *pdev;
> void __iomem *base;
>
> - if (!MACH_IS_ATARI || !ATARIHW_PRESENT(IDE))
> - return -ENODEV;
> -
> - pr_info(DRV_NAME ": Atari Falcon PATA controller\n");
> + dev_info(&pdev->dev, ": Atari Falcon PATA controller\n");
Please drop the ": ".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
