Hi Bartlomiej,
On Mon, Jul 29, 2019 at 1:52 PM Bartlomiej Zolnierkiewicz
<b.zolnierkie@xxxxxxxxxxx> wrote:
> On 7/29/19 1:30 PM, Geert Uytterhoeven wrote:
> > On Mon, Jul 29, 2019 at 1:10 PM Max Staudt <max@xxxxxxxxx> wrote:
> >> On 07/29/2019 11:05 AM, Geert Uytterhoeven wrote:
> >>>> --- a/drivers/ata/pata_buddha.c
> >>>> +++ b/drivers/ata/pata_buddha.c
> >>>
> >>>> +static const struct zorro_device_id pata_buddha_zorro_tbl[] = {
> >>>> + { ZORRO_PROD_INDIVIDUAL_COMPUTERS_BUDDHA, },
> >>>> + { ZORRO_PROD_INDIVIDUAL_COMPUTERS_CATWEASEL, },
> >>>> + { ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF, },
> >>>
> >>> drivers/net/ethernet/8390/zorro8390.c also matches against
> >>> ZORRO_PROD_INDIVIDUAL_COMPUTERS_X_SURF, while only
> >>> a single zorro_driver can bind to it. Hence you can no longer use both
> >>> IDE and Ethernet on X-Surf :-(
> >>> Before, this worked, as the IDE driver just walked the list of devices.
> >>
> >> Okay, now this gets dirty.
> >>
> >> The reason why I've submitted this patch is to allow pata_buddha to be built into the kernel at all. Without this patch, its initcall would be called before the Zorro structures are initialised, hence not finding any boards.
> >
> > IC. I wasn't aware of the new pata_buddha.c driver not working at all
> > when builtin.
>
> Isn't the same true also for old buddha.c driver?
> (please see below)
> >> What shall I do? Maybe as a stop-gap measure, we could hard-code a
> >> module_init() again, just for X-Surf? It's been good enough until a
> >> few weeks ago, so what could go wrong ;)
> >
> > In the short run: keep on using drivers/ide/buddha.c?
>
> IDE subsystem is initialized even before libata so I cannot see how
> this would help?
>
> drivers/Makefile:
> ...
> obj-$(CONFIG_IDE) += ide/
> obj-y += scsi/
> obj-y += nvme/
> obj-$(CONFIG_ATA) += ata/
> ...
> obj-$(CONFIG_ZORRO) += zorro/
> ...
>
> What am I missing?
Oops, that might be an incorrect assumption on my side...
(note to myself: never assume existing code is actually working as
expected ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
