Re: [PATCH RFC 1/2] m68k/atari: add platform device for Falcon IDE port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sergei,

Am 23.06.2019 um 21:06 schrieb Sergei Shtylyov:
Hello!

On 20.06.2019 23:47, Michael Schmitz wrote:

Autoloading of Falcon IDE driver modules requires converting
these drivers to platform drivers.

Add platform device for Falcon IDE interface in Atari platform
setup code in preparation for this.

Add Falcon IDE base address in Atari hardware address header.

Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
---
  arch/m68k/atari/config.c        |   20 ++++++++++++++++++++
  arch/m68k/include/asm/atarihw.h |    6 ++++++
  2 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/arch/m68k/atari/config.c b/arch/m68k/atari/config.c
index ca8469e..2d7133a 100644
--- a/arch/m68k/atari/config.c
+++ b/arch/m68k/atari/config.c
@@ -896,6 +896,21 @@ static void isp1160_delay(struct device *dev, int
delay)
  };
  #endif
  +#if IS_ENABLED(CONFIG_PATA_FALCON)
+static const struct resource atari_falconide_rsrc[] __initconst = {
+    {
+        .flags = IORESOURCE_MEM,
+        .start = FALCON_IDE_BASE,
+        .end   = FALCON_IDE_BASE+0x40,

   You probably forgot to subtract 1 here...

Well spotted. That's inconsequential however, as there's no overlap with other IO adresses used in that region, and everything has been mapped into kernel space by early arch startup.

Will fix in the next iteration.

Cheers,

	Michael


+    },
+    {
+        .flags = IORESOURCE_IRQ,
+        .start = IRQ_MFP_FSCSI,
+        .end   = IRQ_MFP_FSCSI,
+    },
+};
+#endif
+
  int __init atari_platform_init(void)
  {
      int rv = 0;
[...]

MBR, Sergei



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux