On 14. 06. 19, 10:24, Sergei Shtylyov wrote: >> --- a/drivers/ata/sata_mv.c >> +++ b/drivers/ata/sata_mv.c >> @@ -2098,12 +2098,10 @@ static int mv_qc_prep(struct ata_queued_cmd *qc) >> * non-NCQ mode are: [RW] STREAM DMA and W DMA FUA EXT, none >> * of which are defined/used by Linux. If we get here, this >> * driver needs work. >> - * >> - * FIXME: modify libata to give qc_prep a return value and >> - * return error here. >> */ >> - BUG_ON(tf->command); >> - break; >> + ata_port_err(ap, "%s: unsupported command: %d\n", __func__, >> + tf->command); > > I'd use "%x" here instead of "%d". Hi, that makes sense. Fixed locally to %.2x as the commands are defined as such. Waiting for more comments before [v2] :). thanks, -- js suse labs
