Re: [PATCH] sata_rcar: Remove ata_host_alloc() error printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 29, 2019 at 05:22:09PM +0200, Geert Uytterhoeven wrote:
> ata_host_alloc() can only fail due to memory allocation failures.
> Hence there is no need to print a message, as the memory allocation core
> code already takes care of that.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

Jens, could you consider picking this one up?

> ---
>  drivers/ata/sata_rcar.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
> index 59b2317acea99e46..3495e1733a8e6756 100644
> --- a/drivers/ata/sata_rcar.c
> +++ b/drivers/ata/sata_rcar.c
> @@ -909,7 +909,6 @@ static int sata_rcar_probe(struct platform_device *pdev)
>  
>  	host = ata_host_alloc(dev, 1);
>  	if (!host) {
> -		dev_err(dev, "ata_host_alloc failed\n");
>  		ret = -ENOMEM;
>  		goto err_pm_put;
>  	}
> -- 
> 2.17.1
> 



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux