On Wed, Dec 5, 2018 at 1:38 AM Jens Axboe <axboe@xxxxxxxxx> wrote: > On 12/4/18 5:36 PM, Marek Vasut wrote: > > On 12/05/2018 01:16 AM, Jens Axboe wrote: > >> On 11/13/18 6:01 AM, Linus Walleij wrote: > >>> Instead of passing GPIO numbers directly to the PalmLD > >>> ATA driver, pass GPIO descriptors from the board file and > >>> handle these in the driver. > >> > >> Applied, thanks. > > > > I provided feedback, seems it was ignored :( > > Sorry, I missed that then. Linus, if feedback needs to be addressed, > just do an incremental patch. OK such things happens, I'll make a follow-up patch creating a state container as requested by Marek. I first thought it's unintuitive since I suspect it is mechanically impossible to connect more than one ATA interface to the Palm LifeDrive (judging from how it looks). But it is also nice for consistency and such a small piece of work so why not :) Are you using this device with OpenEmbedded userspace or something different? Yours, Linus Walleij