On 11/13/2018 02:01 PM, Linus Walleij wrote:
> Instead of passing GPIO numbers directly to the PalmLD
> ATA driver, pass GPIO descriptors from the board file and
> handle these in the driver.
>
> Cc: Marek Vasut <marek.vasut@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
[...]
> +++ b/drivers/ata/pata_palmld.c
> @@ -26,17 +26,14 @@
> #include <linux/irq.h>
> #include <linux/platform_device.h>
> #include <linux/delay.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>
> #include <scsi/scsi_host.h>
> #include <mach/palmld.h>
>
> #define DRV_NAME "pata_palmld"
>
> -static struct gpio palmld_hdd_gpios[] = {
> - { GPIO_NR_PALMLD_IDE_PWEN, GPIOF_INIT_HIGH, "HDD Power" },
> - { GPIO_NR_PALMLD_IDE_RESET, GPIOF_INIT_LOW, "HDD Reset" },
> -};
> +static struct gpio_desc *palmld_pata_power;
Can't this be placed in some per-driver-instance data ?
Looks OK otherwise.
[...]
--
Best regards,
Marek Vasut
