From: Joris Gutjahr <joris.gutjahr@xxxxxxxxx> Date: Sun, 28 Oct 2018 17:45:46 +0100 > I fixed this coding style error I got after running > checkpatch --file on this file. > The problem was that the whole case block was on one line. > > Signed-off-by: Joris Gutjahr <joris.gutjahr@xxxxxxxxx> Frankly I think the existing code is more compact and easier to read and understand. Checkpatch is a tool, and it's results need be interpreated and evaluated by human beings. It's not to be taken as the final verdict. I'm not applying this, sorry.