On 11/06/2018 05:42 AM, Chaohong guo wrote: > Interrupt vector 0 is valid on some platform. ixp4xxx driver wrongly > treated interrupt vector 0 as invalid. We fix it in libata, and fix it > in this driver as well. > > Signed-off-by: Chaohong guo <chaohong.guo@xxxxxxxxx> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > --- > drivers/ata/pata_ixp4xx_cf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c > index 0b0d93065f5a..303337d1c1f7 100644 > --- a/drivers/ata/pata_ixp4xx_cf.c > +++ b/drivers/ata/pata_ixp4xx_cf.c > @@ -169,7 +169,7 @@ static int ixp4xx_pata_probe(struct platform_device *pdev) > return -ENOMEM; > > irq = platform_get_irq(pdev, 0); > - if (irq) > + if (irq >= 0) The amount of sloppy code around platform_get_irq() is really impressive... MBR, Sergei
