Sorry for putting u into the reviewed-by before getting your ack. I will split this patch and re-send it. -chaohong > -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov@xxxxxxxxxxxxxxxxxx] > Sent: Monday, November 5, 2018 12:40 AM > To: Guo, Chaohong <chaohong.guo@xxxxxxxxx>; linux-ide@xxxxxxxxxxxxxxx > Subject: Re: [PATCH libata v2] Allow system to allocate IRQ 0 to ATA devices > > Hello! > > On 11/2/2018 4:46 AM, Chaohong guo wrote: > > > Interrupt vector 0 can be used on some platform. In libata, the > > routine > > ata_host_activate() considers irq=0 as invalid. As a result, when > > running linux in non-root cell of Jailhouse, if we allocate just one > > PCI ATA device to the guest, the device will get an IRQ of value 0. > > Although IRQ0 is perfectly legal, ATA device will fail to start up. > > Besides, some ATA drivers have the same bug and consider irq0 as > > invalid, So, we fix them as well. > > > > Signed-off-by: Chaohong guo <chaohong.guo@xxxxxxxxx> > > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > I haven't explicitly given you my Reviewed-by: tag, you can't add it just > because I commented to your patch. > > MBR, Sergei