On 10/18/2018 02:41 PM, Christoph Hellwig wrote: >> +static int __init pata_buddha_init_one(void) >> +{ >> + struct zorro_dev *z = NULL; >> + >> + while ((z = zorro_find_device(ZORRO_WILDCARD, z))) { > > I'm not really an m68k expert, but shouldn't this implement a > struct zorro_driver instead? (or maybe two of them as xsurf > seems sufficiently different). I didn't want to introduce too many changes over old IDE's driver in the initial version of the libata driver as I can't test them myself. Once the new driver is verified to work I plan to convert it into proper Zorro_driver. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics