On 2018/8/17 21:23, zhong jiang wrote: > We should use NULL to compare with pointer-typed value rather than > 0. The issue is detected with the help of Coccinelle. > > Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> > --- > drivers/ide/pmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c > index c5b902b..673734b 100644 > --- a/drivers/ide/pmac.c > +++ b/drivers/ide/pmac.c > @@ -1682,7 +1682,7 @@ static int pmac_ide_init_dma(ide_hwif_t *hwif, const struct ide_port_info *d) > /* We won't need pci_dev if we switch to generic consistent > * DMA routines ... > */ > - if (dev == NULL || pmif->dma_regs == 0) > + if (dev == NULL || pmif->dma_regs == NULL) > return -ENODEV; > /* > * Allocate space for the DBDMA commands. Maybe if (!dev || !pmif->dma_regs) is better, Will repost in v2. Thanks, zhong jiang
