On Mon, Aug 13, 2018 at 4:14 PM Tejun Heo <tj@xxxxxxxxxx> wrote: > So, one thought I have is that this doesn't really add any new > capabilities. The information is fully discoverable from userspace > and interpreting the data requires quite a bit of heuristics. So, do > we really need this in the kernel? I do not intend to add all of SMART or anything just the temperature sensor(s). This is because the kernel has a thermal framework, drivers/thermal, that can be used to define thermal zones and cooling devices for them. It has surfaced that some NAS devices rely on the sensor in the harddisk for their cooling policy, as they have no other sensor, but they have a fan. To utilize the sensor for the thermal zone, it must be known to the kernel. Being able to simply use the existing hwmon ABI to read these sensors appear to have a value on its own and rely on one userspace tool (sensors) instead of several which also seem sparingly maintained (hddtemp). smartmontools make good use of the data, but it has other main purposes than temperature monitoring and is a pretty big hammer for that. Yours, Linus Walleij
