On 7/31/18 1:51 PM, Kees Cook wrote: > This is a follow-up to commit f7068114d45e ("sr: pass down correctly > sized SCSI sense buffer") which further cleans up and removes needless > sense character array buffers and "struct request_sense" usage in favor > of the common "struct scsi_sense_hdr". > > First, drop a bunch of unused sense buffers: > [PATCH 1/9] ide-cd: Drop unused sense buffers > [PATCH 2/9] scsi: cxlflash: Drop unused sense buffers > > Next, allow the sense buffer to be usable outside SCSI tree: > [PATCH 3/9] scsi: build scsi_common.o for all scsi passthrough request users > [PATCH 4/9] target: don't depend on SCSI > > Then move all request_sense usage to scsi_sense_hdr: > [PATCH 5/9] block: Switch struct packet_command to use struct scsi_sense_hdr > > And do some further cleanups for scsi_sense_hdr now that we can: > [PATCH 6/9] ide-cd: Remove redundant sense buffer > [PATCH 7/9] cdrom: Use struct scsi_sense_hdr internally > > Finally add a build-time check to make sure we don't pass bad buffer sizes: > [PATCH 8/9] libata-scsi: Move sense buffers onto stack > [PATCH 9/9] scsi: Check sense buffer size at build time Thanks Kees, applied for 4.19. Note that I hand applied patch #5 and #9, since they did not apply directly to the block tree. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html