Re: [PATCH v2 1/3] ata: ahci: rpm_put port on port_stop to match rpm_get in port_start

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Fri, Apr 20, 2018 at 10:18:32AM +0000, 0v3rdr0n3@xxxxxxxxx wrote:
> From: Samuel Morris <samorris@xxxxxxxxxxx>
> 
> Signed-off-by: Samuel Morris <samorris@xxxxxxxxxxx>
> ---
>  drivers/ata/libahci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index 7adcf3caabd0..8eec099a605f 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -2432,6 +2432,8 @@ static void ahci_port_stop(struct ata_port *ap)
>  	 * re-enabling INTx.
>  	 */
>  	writel(1 << ap->port_no, host_mmio + HOST_IRQ_STAT);
> +
> +	ahci_rpm_put_port(ap);

Can you add a comment explaining that this is to balance out the final
ahci_port_resume() call in port_start?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux