init_chipset_pdcnew() is never called in atomic context. This function is only set as ".init_chipset" in struct ide_port_info. Despite never getting called from atomic context, init_chipset_pdcnew() calls mdelay() to busily wait. This is not necessary and can be replaced with msleep() to avoid busy waiting. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx> --- drivers/ide/pdc202xx_new.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ide/pdc202xx_new.c b/drivers/ide/pdc202xx_new.c index b33646b..a654491 100644 --- a/drivers/ide/pdc202xx_new.c +++ b/drivers/ide/pdc202xx_new.c @@ -403,7 +403,7 @@ static int init_chipset_pdcnew(struct pci_dev *dev) outb(pll_ctl1, sec_dma_base + 0x03); /* Wait the PLL circuit to be stable */ - mdelay(30); + msleep(30); #ifdef DEBUG /* -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
