Thanks for your kindly review. Sorry, I only move all the "+ " to the end of the line. Missing the "| " operators. I would change them all later. Thanks. BR Richard Zhu -----Original Message----- From: Tejun Heo [mailto:htejun@xxxxxxxxx] On Behalf Of Tejun Heo Sent: Tuesday, March 27, 2018 9:53 PM To: Richard Zhu <hongxing.zhu@xxxxxxx> Cc: hdegoede@xxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx Subject: Re: [PATCH v1] ahci: imx: add the imx8qm ahci sata support On Tue, Mar 27, 2018 at 01:43:23PM +0800, Richard Zhu wrote: > + regmap_update_bits(imxpriv->gpr, > + IMX8QM_CSR_PHYX2_OFFSET, > + IMX8QM_PHY_PIPE_RSTN_0 > + | IMX8QM_PHY_PIPE_RSTN_OVERRIDE_0, ^^ ? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html