Re: [RFC] ahci: imx: fix the build warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 20, 2018 at 01:01:34PM +0800, Richard Zhu wrote:
> Fix the following build warning introduced by commit.
> e5878732a521 ("ahci: imx: add the imx6qp ahci sata support")
> 
> drivers/ata/ahci_imx.c: In function 'imx_sata_disable':
> drivers/ata/ahci_imx.c:478:2: warning: enumeration value 'AHCI_IMX53'
> not handled in switch [-Wswitch]
>   switch (imxpriv->type) {
> 	    ^~~~~~
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> ---
>  drivers/ata/ahci_imx.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
> index 577458f..f898a0f 100644
> --- a/drivers/ata/ahci_imx.c
> +++ b/drivers/ata/ahci_imx.c
> @@ -476,6 +476,9 @@ static void imx_sata_disable(struct ahci_host_priv *hpriv)
>  		return;
>  
>  	switch (imxpriv->type) {
> +	case AHCI_IMX53:
> +		break;
> +

Can we just add default: as the last entry or just switch it to if/else?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux