Re: [PATCH] ata: do not schedule hot plug if it is a sas host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2018/2/28 2:22, Tejun Heo wrote:
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
>index 11c3137d7b0a..97aeac45b22c 100644
>--- a/drivers/ata/libata-eh.c
>+++ b/drivers/ata/libata-eh.c
>@@ -1384,7 +1384,9 @@ void ata_eh_detach_dev(struct ata_device *dev)
>
>  	if (ata_scsi_offline_dev(dev)) {
>  		dev->flags |= ATA_DFLAG_DETACHED;
>-		ap->pflags |= ATA_PFLAG_SCSI_HOTPLUG;
>+		/* libsas handles the hotplug itself */
>+		if (!(ap->flags & ATA_FLAG_SAS_HOST))
>+			ap->pflags |= ATA_PFLAG_SCSI_HOTPLUG;
Can you please move the conditional to where we're consuming the flag
instead?


OK, will send a new version.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux