RE: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please ignore this, it is a duplicated patch.

Regards,
Yuantian

> -----Original Message-----
> From: yuantian.tang@xxxxxxx [mailto:yuantian.tang@xxxxxxx]
> Sent: Friday, September 30, 2016 2:13 PM
> To: tj@xxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx
> Cc: Y.T. Tang <yuantian.tang@xxxxxxx>; Y.T. Tang <yuantian.tang@xxxxxxx>
> Subject: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a SoC"
> 
> From: Tang Yuantian <Yuantian.Tang@xxxxxxx>
> 
> This reverts commit 640847298e2b7f19 ("ahci: qoriq: Disable NCQ on ls2080a
> SoC")
> 
> The erratum has been fixed in ls2080a v2.0 and later soc.
> In reality, customer will not get any ls2080a v1.0 soc. Neither apply to any
> products. So reverting this commit won't create any side effect.
> 
> Blacklisting v2.0 could also be a option, but that needs to check the soc
> version which is not suitable in the driver.
> 
> Signed-off-by: Tang Yuantian <yuantian.tang@xxxxxxx>
> ---
>  drivers/ata/ahci_qoriq.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index
> 925c4b6..1eba8df 100644
> --- a/drivers/ata/ahci_qoriq.c
> +++ b/drivers/ata/ahci_qoriq.c
> @@ -136,7 +136,7 @@ static struct ata_port_operations ahci_qoriq_ops = {
>  	.hardreset	= ahci_qoriq_hardreset,
>  };
> 
> -static struct ata_port_info ahci_qoriq_port_info = {
> +static const struct ata_port_info ahci_qoriq_port_info = {
>  	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
>  	.pio_mask	= ATA_PIO4,
>  	.udma_mask	= ATA_UDMA6,
> @@ -221,12 +221,6 @@ static int ahci_qoriq_probe(struct platform_device
> *pdev)
>  	if (rc)
>  		goto disable_resources;
> 
> -	/* Workaround for ls2080a */
> -	if (qoriq_priv->type == AHCI_LS2080A) {
> -		hpriv->flags |= AHCI_HFLAG_NO_NCQ;
> -		ahci_qoriq_port_info.flags &= ~ATA_FLAG_NCQ;
> -	}
> -
>  	rc = ahci_platform_init_host(pdev, hpriv, &ahci_qoriq_port_info,
>  				     &ahci_qoriq_sht);
>  	if (rc)
> --
> 2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux