> -----Original Message----- > From: Tejun Heo [mailto:htejun@xxxxxxxxx] On Behalf Of Tejun Heo > Sent: Thursday, September 29, 2016 4:55 PM > To: Y.T. Tang <yuantian.tang@xxxxxxx> > Cc: linux-ide@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] ahci: qoriq: Revert "ahci: qoriq: Disable NCQ on ls2080a > SoC" > > Hello, > > On Wed, Sep 28, 2016 at 09:46:12AM +0800, yuantian.tang@xxxxxxx wrote: > > From: Tang Yuantian <Yuantian.Tang@xxxxxxx> > > > > This reverts commit 640847298e2b7f19 ("ahci: qoriq: Disable NCQ on > > ls2080a SoC") > > > > The erratum has been fixed in ls2080a v2.0 and later soc. > > Since ls2080a v1.0 has rarely been released, it can be safely > > reverted. > > Hmm... going by the description, I'm not sure whether this is a good idea. > What's "rarely been released"? Are there chips out in the wild? Can't we > blacklist v2.0+ only? > In reality, customer will not get any ls2080a v1.0 soc. Neither apply to any products. If blacklisting v2.0, we need to check the soc version which is not suitable in the driver. Anyway, reverting this commit won't create any side effect. Regards, Yuantian > Thanks. > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
