On Wed, Aug 24, 2016 at 1:10 AM, Tom Yan <tom.ty89@xxxxxxxxx> wrote: > Btw, I wonder if you need to memset your buffer with 0 first, like > what is done in ata_scsi_rbuf_get. It is not necessary as the defined buffer is completely filled out here. Are you thinking as a sort of future proofing? Ex: In the unlikely event that the SCT Write Same command descriptor is expanded in a future ACS? It is more likely to see the command deprecated and replaced with a new SCT feature. Regardless of how unlikely I would consider a memset here to clear the remainder of the payload. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html