I am not sure about what you mean here. Rejecting SCSI Write Same commands that has its "number of blocks" field set to a value higher than the device's reported Maximum Write Same Length is only natural and mandated by SBC. We have no reason (even if it is practically not a must) not to do it while we are implementing a SCSI-ATA Translation Layer here as long as we advertise Maximum Write Same Length. It does not matter here whether the command ends up being translated to SCT Write Same or TRIM. How high or how lower the limit should be advertised has nothing to do with the checking. FWIW, letting the SCSI/block layer fall back with SD_MAX_WS10_BLOCKS does NOT count as advertising Maximum Write Same Length, that's why we may or may not (in terms of SBC) check n_block against it if we are really gonna leave ata_scsiop_inq_b0 in libata-scsi untouched. On 22 August 2016 at 22:07, Shaun Tancheff <shaun.tancheff@xxxxxxxxxxx> wrote: > On Mon, Aug 22, 2016 at 3:14 PM, Tom Yan <tom.ty89@xxxxxxxxx> wrote: >> On 23 August 2016 at 03:43, Shaun Tancheff <shaun.tancheff@xxxxxxxxxxx> wrote: >>> >>> Why would we enforce upper level limits on something that doesn't >>> have any? >> >> If we advertise a limit in our SATL, it makes sense that we should >> make sure the behaviour is consistent when we issue a write same >> through the block layer / ioctl and when we issue a SCSI Write Same >> command directly (e.g. with sg_write_same). IMHO that's pretty much >> why SBC would mandate such behaviour as well. > > Breaking would be advertising a limit that is too high and failing. > Advertising a lower limit and succeeding may not be ideal for all > possible use cases, but it's not breaking behaviour. > >>> >>> If the upper level, or SG_IO, chooses to set a timeout of 10 hours and >>> wipe a whole disk it should be free to do so. >>> >> >> That's why I said, "if you are going to advertise an Maximum Write Same Length". > > -- > Shaun Tancheff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
