Hi, On 01/11/2016 09:33 AM, Mark Langsdorf wrote: > On 01/08/2016 04:21 PM, Brijesh Singh wrote: >> >> libata-*.c implements the "Enclosure management" style led messages but also has hooks >> to register a custom led control callback. Since Seattle platform does not support >> the "Enclosure management" registers hence ata_port_info we are setting a ATA_FLAG_EM | ATA_FLAG_SW_ACIVITY >> to indicate that we can still handle the led messages by our registered callback. I see >> that sata_highbank driver is doing something similar. > > The sata_highbank driver is doing it wrong and shouldn't have been > accepted in its current condition. Enclosure management really should > be a separate device. Please don't use it as an example. > Okay. Thanks for letting me know. Should I consider extending the generic driver to handle this Seattle platform specific feature or go with a new platform driver approach (i.e the one I am doing right now) ? -Brijesh -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
