Re: [PATCH v2 0/2] ahci per-port msix support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 02, 2015 at 02:23:02PM -0500, Tejun Heo wrote:
> On Sun, Nov 01, 2015 at 01:43:35PM -0500, Dan Williams wrote:
> > Changes since v1 [1]:
> > 
> > 1/ Clean up "nvec = min(nvec, n_ports);" statement (Tejun)
> > 
> > 2/ Drop threaded interrupt handling option for now.
> > 
> > [1]: http://marc.info/?l=linux-ide&m=144623970817213&w=2
> 
> Applied to libata/for-4.4.

Dan, I got the following build failures from kbuild and reverted the
two patches from for-4.4.  It's too late for this merge window anyway.
Let's try the next one.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/libata for-4.4
head:   3758b0e5028c4b5083f2148ddc06b719d73e7627
commit: 6cb1c51aa65039ab3860c9741f9a190b7ab199cb [19/20] ahci: per-port msix support
config: mips-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 6cb1c51aa65039ab3860c9741f9a190b7ab199cb
        # save the attached .config to linux build tree
        make.cross ARCH=mips

All errors (new ones prefixed by >>):

   drivers/ata/libahci.c: In function 'ahci_host_activate_multi_irqs':
>> drivers/ata/libahci.c:2492:4: error: invalid use of undefined type 'struct msix_entry'
       irq = hpriv->msix[i].vector;
       ^
>> drivers/ata/libahci.c:2492:21: error: dereferencing pointer to incomplete type 'struct msix_entry'
       irq = hpriv->msix[i].vector;
                        ^

vim +2492 drivers/ata/libahci.c

  2486           */
  2487          for (i = 0; i < host->n_ports; i++) {
  2488                  struct ahci_port_priv *pp = host->ports[i]->private_data;
  2489                  int irq;
  2490
  2491                  if (hpriv->flags & AHCI_HFLAG_MULTI_MSIX)
> 2492                          irq = hpriv->msix[i].vector;
  2493                  else
  2494                          irq = hpriv->irq + i;
  2495

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux