Hello, Generally looks good to me. One nitpick. On Fri, Oct 30, 2015 at 05:09:40PM -0400, Dan Williams wrote: > + if (flags & AHCI_HFLAG_MULTI_MSIX) { > + if (nvec < n_ports) > + return -ENODEV; > + else > + nvec = min(nvec, n_ports); Maybe the following is easier? if (nvec < n_ports) return -ENODEV; nvec = n_ports; Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html