On Sat, Oct 17, 2015 at 5:30 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Hello. > > On 10/17/2015 2:48 PM, vinayak.kale@xxxxxxxxx wrote: > >> From: Vinayak Kale <vinayak.kale@xxxxxxxxxxx> >> >> This patch is needed to make NCQ commands with FPDMA protocol value >> (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface. >> >> Signed-off-by: Vinayak Kale <vinayak.kale@xxxxxxxxxxx> >> --- >> drivers/ata/libata-scsi.c | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c >> index 0d7f0da..5b0a5ab 100644 >> --- a/drivers/ata/libata-scsi.c >> +++ b/drivers/ata/libata-scsi.c > > [...] >> >> @@ -2963,7 +2965,7 @@ static unsigned int ata_scsi_pass_thru(struct >> ata_queued_cmd *qc) >> tf->hob_lbal = cdb[7]; >> tf->hob_lbam = cdb[9]; >> tf->hob_lbah = cdb[11]; >> - tf->flags |= ATA_TFLAG_LBA48; >> + tf->flags |= (ATA_TFLAG_LBA48 | ATA_TFLAG_LBA); > > > Parens not needed here. That's quite neat :-) Thanks, will change it in V2. > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html