Hello, Christoph. On Mon, Oct 05, 2015 at 08:01:17AM +0200, Christoph Hellwig wrote: > On Sun, Oct 04, 2015 at 01:34:29PM -0400, Tejun Heo wrote: > > Hmmm... has this actually been observed? All these are run under ata > > port lock and so is the command issue path, so even if the tag gets > > reissued, it will have to wait till the completion path is done. > > No - I stumbled over this while trying to debug > https://lkml.org/lkml/2015/6/25/620 (which could use some libata experience, > btw), but it didn't help. I still would like to see it fixes as similar > patterns in SCSI drivers have caused crashes. So, given the locking, the bug doesn't exist. I don't think switching to a safer pattern is a bad thing but the patch needs updated description and comment explanining that it isn't a bug fix and the specific ordering isn't strictly necessary. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
