On Sun, Jun 14, 2015 at 07:45:49PM -0400, Martin K. Petersen wrote:
> >>>>> "David" == David Milburn <dmilburn@xxxxxxxxxx> writes:
>
> David> Have you seen both commands fail on any of the Samsung SSD 840
> David> EVO drives?
>
> David> # dmesg | grep Samsung [ 2.254443] ata10.00: ATA-9: Samsung SSD
> David> 840 EVO 1TB, EXT0BB6Q, max UDMA/133
>
> I have an 840 EVO in my test box. However, yours is running an older
> firmware that predates queued TRIM support. So I guess that's
> expected...
Ahh, ok, would it be ok to slightly change the error message to indicate
the drive doesn't support queued TRIM.
Thanks.
Signed-off-by: David Milburn <dmilburn@xxxxxxxxxx>
---
drivers/ata/libata-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 8e533f7..601d4f2 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2128,6 +2128,7 @@ static int ata_dev_config_ncq(struct ata_device *dev,
0, ap->sector_buf, 1);
if (err_mask) {
ata_dev_dbg(dev,
+ "Drive doesn't support queued TRIM, "
"failed to get NCQ Send/Recv Log Emask 0x%x\n",
err_mask);
} else {
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
