Re: [PATCH v6 1/1] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tejun,

On Mon, May 11, 2015 at 4:58 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Hello, Suman.
>
> On Mon, May 11, 2015 at 02:06:15PM +0530, Suman Tripathi wrote:
>> -#ifdef CONFIG_ACPI
>> -static const struct acpi_device_id xgene_ahci_acpi_match[] = {
>> -     { "APMC0D0D", },
>> -     { }
>> -};
>> -MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
>> -#endif
>> -
>> -static const struct of_device_id xgene_ahci_of_match[] = {
>> -     {.compatible = "apm,xgene-ahci"},
>> -     {},
>> -};
>> -MODULE_DEVICE_TABLE(of, xgene_ahci_of_match);
>
> I applied the patch as-is this time but please don't combine code
> movement with actual changes in the future.  Split them out to
> separate patches.  It makes the changes a lot easier to follow and
> verify.

Sorry . I will take care of it next time onwards.
>
> Thanks.
>
> --
> tejun



-- 
Thanks,
with regards,
Suman Tripathi
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux