On 05/05/2015 03:54 AM, Martin K. Petersen wrote:
> Support for the READ/WRITE LOG DMA EXT commands can be signaled either
> in page 119 or page 120. We should check both pages.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> ---
> include/linux/ata.h | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index b666b773e111..fed36418dd1c 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -704,9 +704,19 @@ static inline bool ata_id_wcache_enabled(const u16 *id)
>
> static inline bool ata_id_has_read_log_dma_ext(const u16 *id)
> {
> + /* Word 86 must have bit 15 set */
> if (!(id[ATA_ID_CFS_ENABLE_2] & (1 << 15)))
> return false;
> - return id[ATA_ID_COMMAND_SET_3] & (1 << 3);
> +
> + /* READ LOG DMA EXT support can be signaled either from word 119
> + * or from word 120. The format is the same for both words: Bit
> + * 15 must be cleared, bit 14 set and bit 3 set.
> + */
> + if ((id[ATA_ID_COMMAND_SET_3] & 0xC008) == 0x4008 ||
> + (id[ATA_ID_COMMAND_SET_4] & 0xC008) == 0x4008)
> + return true;
> +
> + return false;
> }
>
> static inline bool ata_id_has_sense_reporting(const u16 *id)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
