> Please note that we should not end up with the division by zero with > existing host drivers. EZ(v, unit) checks for v being zero and t->udma > is non-zero only for XFER_UDMA_* xfer modes. Currently none of host > drivers calls ata_timing_compute() on xfer mode >= XFER_UDMA_0 with > the zero UT argument. Such usage will be an error and while the old > code explodes immediately, the new one will silently accept it (which > could theoretically result in the wrong timing being set).. Having gone back over them with your additional point I missed noted all seems to be good. I'll drop the patch from my queue. I don't see any point adding extra checks - it's not as if anyone is writing many new PATA drivers. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
