Hi Sergei, On Thu, Mar 19, 2015 at 02:33:32PM +0300, Sergei Shtylyov wrote: > Hello. > > On 3/19/2015 4:23 AM, Brian Norris wrote: > > >Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> > >--- > >Light dependency on: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/331921.html > >for the surrounding text. > > > arch/arm/boot/dts/bcm7445.dtsi | 36 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > >diff --git a/arch/arm/boot/dts/bcm7445.dtsi b/arch/arm/boot/dts/bcm7445.dtsi > >index 9eaeac8dce1b..7a7c4d8c2afe 100644 > >--- a/arch/arm/boot/dts/bcm7445.dtsi > >+++ b/arch/arm/boot/dts/bcm7445.dtsi > >@@ -108,6 +108,42 @@ > > brcm,int-map-mask = <0x25c>, <0x7000000>; > > brcm,int-fwd-mask = <0x70000>; > > }; > >+ > >+ sata@f045a000 { > > Hm, why the <unit-address> part of the name doesn't correspond to the > "reg" prop? Whoops. This .dtsi file is confusing, since none of the Broadcom DTS's I deal with have the 'ranges' property building in an 0xf0000000 offset in the /rdb node. All our DTS's give absolute register addresses, not relative. This discrepancy is a copy-and-paste where I fixed the functional aspect (the 'reg' property) but overlooked the cosmetic (the name / unit-address). We considered just reworking the /rdb node so that it drops the 0xf0000000 offset, in order to be more consistent and to avoid "mistakes" like this. I could either do that (and use 0xf045a000 in both places) or just fix the unit address you pointed out. > >+ compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci"; > >+ reg-names = "ahci", "top-ctrl"; > >+ reg = <0x45a000 0xa9c>, <0x458040 0x24>; > >+ interrupts = <GIC_SPI 30 0>; > >+ #address-cells = <1>; > >+ #size-cells = <0>; > [...] > >+ sata_phy: sata-phy@f0458100 { > > Same question here... Same answer :) > >+ compatible = "brcm,bcm7445-sata-phy", "brcm,phy-sata3"; > >+ reg = <0x458100 0x1e00>, <0x45804c 0x10>; > [...] Thanks for the review. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
