From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Mon, 2 Feb 2015 23:30:34 +0100 The return value from the phy_power_off() function was not used by the mv_platform_remove() function. Let us improve error detection and eventually return a corresponding failure code. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/ata/sata_mv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index f8c33e3..4f9bc33 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -4203,7 +4203,7 @@ static int mv_platform_remove(struct platform_device *pdev) { struct ata_host *host = platform_get_drvdata(pdev); struct mv_host_priv *hpriv = host->private_data; - int port; + int port, rc; ata_host_detach(host); if (!IS_ERR(hpriv->clk)) { @@ -4215,7 +4215,9 @@ static int mv_platform_remove(struct platform_device *pdev) clk_disable_unprepare(hpriv->port_clks[port]); clk_put(hpriv->port_clks[port]); } - phy_power_off(hpriv->port_phys[port]); + rc = phy_power_off(hpriv->port_phys[port]); + if (rc) + return rc; } return 0; } -- 2.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html