On Mon, Jan 19, 2015 at 10:27:31AM -0600, David Milburn wrote:
> void ata_sff_flush_pio_task(struct ata_port *ap)
> {
> + struct Scsi_Host *host = ap->scsi_host;
> + unsigned long flags;
> +
> DPRINTK("ENTER\n");
>
> cancel_delayed_work_sync(&ap->sff_pio_task);
> +
> + /* prevent racing with ISR's use of ap->hsm_task_state */
Can we have a more descriptive comment please? lock, assign, unlock
sequence is pretty unusual, so let's give the full explanation here.
> + spin_lock_irqsave(host->host_lock, flags);
> ap->hsm_task_state = HSM_ST_IDLE;
> + spin_unlock_irqrestore(host->host_lock, flags);
Other than that, yeah, nice spotting.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
