On Fri, 2014-12-05 at 09:51 -0500, Tejun Heo wrote: > > I just feel bad about disabling the feature for the many existing users > > (and there are quite a few) that are using well-behaved drives in their > > RAID deployments. And the filesystem folks have been begging for the > > zeroout discard variant that I posted a few weeks ago. So the users are > > there. I'm just trying to accommodate them the best I can given the lame > > spec. > > Can you please explain further the practical gains of using trims It's for RAID devices. We'd like to trim RAID devices simply by sending the trim down to every component. If we actually have to translate trim to a write it would damage performance (and defeat the purpose of helping the SSD FTL reuse blocks). However, RAID requires that the redundancy verification of the array components matches otherwise a verify of the RAID fails. This means we have to have a guarantee what the verify read of a trimmed block of a RAID component will return. So for RAID-1, we just need both trimmed components to return the same data (we don't actually care what it is, just that it be mirrored); for RAID-5 we need zeros on every trimmed component, because zero^zero = zero. Conversely, drives that return random junk after a trim cause verification failures, so we just elect not to transmit trim down to them from the RAID layer. James -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html