On Fri, Oct 24, 2014 at 02:47:19PM +0400, Sergei Shtylyov wrote: > Hello. > > On 10/24/2014 6:05 AM, Simon Horman wrote: > > >Unlike other SATA R-Car r8a7790 controllers the r8a7790 ES1 SATA R-Car > >controller needs to be run with DIPM disabled. > > >Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > >--- > >v2 > >* Handle ES1 in sata_rcar_init_controller() > >--- > > Documentation/devicetree/bindings/ata/sata_rcar.txt | 3 ++- > > drivers/ata/sata_rcar.c | 11 +++++++++++ > > 2 files changed, 13 insertions(+), 1 deletion(-) > > [...] > >diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c > >index 61eb6d7..b398513 100644 > >--- a/drivers/ata/sata_rcar.c > >+++ b/drivers/ata/sata_rcar.c > [...] > >@@ -763,6 +764,10 @@ static void sata_rcar_setup_port(struct ata_host *host) > > ap->udma_mask = ATA_UDMA6; > > ap->flags |= ATA_FLAG_SATA; > > > >+ if (priv->type == RCAR_R8A7790_ES1_SATA) { > >+ ap->flags |= ATA_FLAG_NO_DIPM; > >+ } > >+ > > Please, please drop {}. I think checkpatch.pl should complain about them... Thanks, done. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html