On Mon, Sep 15, 2014 at 04:44:52PM +0900, Tejun Heo wrote:
> On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote:
> > [suman] : So the posted version is acceptable ? Any others comments on this
> > patch ?
>
> I'm suggesting setting ctx->cs_mux to NULL on failure. IOW,
>
> if (res) {
> ctx->csr_mux = devm_ioremap_resources();
> if (IS_ERR(ctx->csr_mux)) {
> print warning or something;
> ctx->csr_mux = NULL;
> }
> }
A much better approach is:
if (res) {
void __iomem *csr = devm_ioremap_resources();
if (IS_ERR(csr)) {
ret = ERR_PTR(csr);
dev_xxx();
goto err;
}
ctx->csr_mux = csr;
}
Then you never end up in the situation where csr_mux contains an error
pointer value - and is much more obvious that is the case.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
