On Tue, Aug 26, 2014 at 12:17:35PM +0530, Suman Tripathi wrote: > Didn't I ask you to update the comment to explain what's going on? > [suman] : can you specifically tell which part of the comment is not clear > and need more explanation? The comment on top of the function doesn't seem to match what's being implemented. In addition, it's generally not very useful to list the actual algorithm in text. Put algorithm in code and explain the summary and rationales for it in the comments. Nothing explains why the retries are being done. > is the existing comment already sufficient? > [suman] : The existing comment is sufficient . No, this isn't. You don't have to include a novel to explain it but there's something different going on here and you should provide information on why this sort of deviation is necessary. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
