On 17 August 2014 16:57, Tejun Heo <tj@xxxxxxxxxx> wrote: > On Sun, Aug 17, 2014 at 07:10:42AM -0400, Tejun Heo wrote: >> On Sat, Aug 16, 2014 at 07:48:04PM +0530, Arjun Sreedharan wrote: >> > scc_bus_softreset not necessarily should return zero. >> > Propagate the error code. >> > >> > Signed-off-by: Arjun Sreedharan <arjun024@xxxxxxxxx> >> >> I reverted the change yesterday but didn't have time to reply. Don't >> send patches you haven't even compile tested. This is the most basic >> of your responsibilities when sending out patches. Okay? Deepest apologies. I had compile tested the first patch; but with a small variable name change, i overlooked the need to compile test. my fault. here's the link to the first patch: https://lkml.org/lkml/diff/2014/8/16/15/1 Also now i feel @err_mask is better. I rest my case further. Thanks. >> >> Applying the updated version to libata/for-3.17-fixes. > > Gees, and your new patch doesn't even apply. What are you doing? > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html