Hi, On Mon, Jul 28, 2014 at 01:27:24PM -0400, Tejun Heo wrote: > On Mon, Jul 28, 2014 at 12:29:56PM +0200, Hans de Goede wrote: > ... > > > + if (!enabled_ports) { > > > + dev_warn(dev, "No port enabled\n"); > > > + return ERR_PTR(-ENODEV); > > > > This should be: > > rc = -ENODEV; > > goto err_out; > > > > Sorry for not catching that sooner. > > > > Other then that the entire series looks good and is: > > > > Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > Antoine, can you please post an updated version of this patch? No > need to repost the whole series. Also, how should the series be > routed? Sure, I'm doing this right away. Regarding the series, Kishon already took patches 1-2. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html