Hi, On Fri, Jul 18, 2014 at 09:47:30AM -0400, Tejun Heo wrote: > On Fri, Jul 18, 2014 at 02:30:02PM +0200, Antoine Ténart wrote: > > @@ -321,6 +321,8 @@ struct ahci_host_priv { > > u32 cap; /* cap to use */ > > u32 cap2; /* cap2 to use */ > > u32 port_map; /* port map to use */ > > + u32 force_port_map; /* force port map */ > > + u32 mask_port_map; /* mask out particular bits */ > > So, ->flags and ->force/mask_port_map are the only input ones, right? > Can we collect them to one spot and label them as such? Yes. So you want a comment about this in the header? Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html