(cc'ing Hans)
Hans, can you please review this patch?
On Wed, Jun 18, 2014 at 05:23:25PM +0300, Mikko Perttunen wrote:
> +#define SATA_CONFIGURATION_0 0x180
> +#define SATA_CONFIGURATION_EN_FPCI BIT(0)
Let's just indent uniformly. The new line should give enough visual
hint on grouping.
> +struct tegra_ahci_priv {
> + struct platform_device *pdev;
> + void __iomem *sata_regs;
> + struct reset_control *sata_rst;
> + struct reset_control *sata_oob_rst;
> + struct reset_control *sata_cold_rst;
> + struct clk *sata_clk;
> + struct clk *sata_oob_clk;
> + struct clk *cml1_clk;
> + struct clk *plle_clk;
> + struct regulator_bulk_data supplies[5];
> + struct phy *padctl_phy;
> +};
And please indent the declared fields uniformly too.
Except for the above nitpicks, generally looks good to me but let's
wait for Hans' review.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
