On Tue, 24 Jun 2014, Varka Bhadram wrote:
> On 06/24/2014 05:45 PM, Lee Jones wrote:
> >On Tue, 24 Jun 2014, Varka Bhadram wrote:
> >>On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote:
> >>>On Monday 16 June 2014 03:56 PM, Antoine Ténart wrote:
> >>>>The Berlin SoC has a two SATA ports. Add a PHY driver to handle them.
> >>>>
> >>>>The mode selection can let us think this PHY can be configured to fit
> >>>>other purposes. But there are reasons to think the SATA mode will be
> >>>>the only one usable: the PHY registers are only accessible indirectly
> >>>>through two registers in the SATA range, the PHY seems to be integrated
> >>>>and no information tells us the contrary. For these reasons, make the
> >>>>driver a SATA PHY driver.
> >>>>
> >>>>Signed-off-by: Antoine Ténart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> >>>>---
> >>>> drivers/phy/Kconfig | 7 ++
> >>>> drivers/phy/Makefile | 1 +
> >>>> drivers/phy/phy-berlin-sata.c | 232 ++++++++++++++++++++++++++++++++++++++++++
> >>>> 3 files changed, 240 insertions(+)
> >>>> create mode 100644 drivers/phy/phy-berlin-sata.c
>
> [...]
>
> >>>>+static struct platform_driver phy_berlin_sata_driver = {
> >>>>+ .probe = phy_berlin_sata_probe,
> >>>>+ .driver = {
> >>>>+ .name = "phy-berlin-sata",
> >>>>+ .owner = THIS_MODULE,
> >>>>+ .of_match_table = phy_berlin_sata_of_match,
> >>use of_match_ptr for of_match_table
> >What use is this?
> >
> >[...]
> >
> of_match_table is NULL for Non-DT based. Better to use the of_match_ptr().
> If driver is DT based 'of_match_table = phy_berlin_sata_of_match'
> else 'of_match_table = NULL'
>
> This is take care by of_match_ptr() macro.
This driver 'depends on OF', so it's okay to always populate
.of_match_table.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
