Re: [PATCH 2/5] ata: ahci_imx: allow hardware parameters to be specified in DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 23, 2014 at 02:32:07PM +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 23, 2014 at 03:26:11PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > Shouldn't all these new properties be documented somewhere in
> > Documentation/devicetree/bindings/ ?
> 
> Shouldn't the existing binding be documented somewhere there?  If someone
> documents the existing implementation, I will happily add to it.  What
> I'm not going to do is to research what the existing bindings are for
> this sucker and do the work that the original submitter should have done
> in the first place.

Let me also point out that these bindings which I'm adding should have
been there right from the very start, before the driver was ever accepted
into mainline.  As the driver stands today, it hard codes the electrical
properties of the Freescale Sabre* boards into the driver, which are
different from the power on defaults of the device - and this is now
something which we're now stuck with since we can't mandate the
properties being present, and the defaults have to be the Sabre*
board values for everything.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux