On Thu, Jun 19, 2014 at 11:38:07AM +0100, One Thousand Gnomes wrote: > On Thu, 19 Jun 2014 13:18:34 +0900 (JST) > Norman Diamond <n0diamond@xxxxxxxxxxx> wrote: > > > If someone has set a password on an ATA/SATA hard drive and someone later connects the drive to a Linux system (before or after booting that Linux system), libata reacts in an unbearably stupid manner. > > Yes. It's well known. Send patches if you care. So far nobody has cared > enough to write the code to use the key rings to deal with drive > unlocking. Hmmm... the reads are prolly from the partition code but I wonder why libata is not classifying it as AC_ERR_DEV. ie. why isn't ata_eh_link_autopsy() delivering just the ATA_EH_REVALIDATE verdict? Another thing to be updated is ata_eh_worth_retry() so that it returns false for IO commands if the device is locked. Or maybe ata_eh_link_autopsy() can set AC_ERR_INVALID for this case. Yeah, that'd make more sense. Anyways, it should be relatively straight forward. Does anyone want to give a crack at it? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
